Azure / functions-action

Enable GitHub developers to deploy to Azure Function Apps using GitHub Actions
MIT License
156 stars 76 forks source link

feat: update nodejs to version 16 #158

Closed fsschmitt closed 2 years ago

fsschmitt commented 2 years ago

Closes #155

Given that node12 is no longer being maintained since April 2022 and the fact that GitHub has deprecated it across all GitHub Actions, this action should also be bumped into the latest LTS version: node16.

More information can be found here: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

Notes to Maintainers

Given that nodejs is deprecated, I've taken the assumption that it should be replaced from nodejs 12 to 16, instead of adding a new test suite just for 16.

Let me know if you believe another approach is better.

fsschmitt commented 2 years ago

@microsoft-github-policy-service agree

github-actions[bot] commented 2 years ago

This PR is idle because it has been open for 14 days with no activity.

fsschmitt commented 2 years ago

@anirudhgarg and @eamonoreilly first of all, sorry for pinging you directly. But I would like to know if there's anything from my side that I can do to fasten this process.

anirudhgarg commented 2 years ago

I have assigned it to the folks who work on this to review

fsschmitt commented 2 years ago

Just as FYI, had to upgrade Typescript version to v4.8.4(latest) due to this issue:

Which was causing build errors such as:

image
patelchandni commented 2 years ago

@fsschmitt Thank you for creating this PR. Merging it to a separate branch to run E2E tests that need secrets. I will merge into master from there.