Closed fsschmitt closed 2 years ago
@microsoft-github-policy-service agree
This PR is idle because it has been open for 14 days with no activity.
@anirudhgarg and @eamonoreilly first of all, sorry for pinging you directly. But I would like to know if there's anything from my side that I can do to fasten this process.
I have assigned it to the folks who work on this to review
Just as FYI, had to upgrade Typescript version to v4.8.4
(latest) due to this issue:
Which was causing build errors such as:
@fsschmitt Thank you for creating this PR. Merging it to a separate branch to run E2E tests that need secrets. I will merge into master from there.
Closes #155
Given that
node12
is no longer being maintained since April 2022 and the fact that GitHub has deprecated it across all GitHub Actions, this action should also be bumped into the latest LTS version:node16
.More information can be found here: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/
Notes to Maintainers
GAE_FA_NODE12_WCON
->GAE_FA_NODE16_WCON
GAE_FA_NODE12_LCON
->GAE_FA_NODE16_LCON
Given that nodejs is deprecated, I've taken the assumption that it should be replaced from nodejs 12 to 16, instead of adding a new test suite just for 16.
Let me know if you believe another approach is better.