Azure / functions-action

Enable GitHub developers to deploy to Azure Function Apps using GitHub Actions
MIT License
152 stars 75 forks source link

Targeting branch for node20 support #231

Closed Julius-Bendt closed 3 months ago

Julius-Bendt commented 3 months ago

I'm trying to target the branch used in this pr (Updates - 229), in order to get node20 support.

Is is a mistake that action.yml is pointing the main file to lib/main.js and not src/main.js?

I tried referencing the action by this branch, and got the following error: File not found: '/home/runner/work/_actions/Azure/functions-action/patelchandni/node20/lib/main.js'

Steps:

# (...)
    steps:
      - name: Download artifact from build job
        uses: actions/download-artifact@v4
        with:
          name: node-app

      - name: Unzip artifact for deployment
        run: unzip release.zip

      - name: 'Run Azure Functions Action'
        uses: Azure/functions-action@patelchandni/node20
        id: fa
        with:
          app-name: 'name'
          slot-name: 'Production'
          package: ${{ env.AZURE_FUNCTIONAPP_PACKAGE_PATH }}
          publish-profile: ${{ secrets.xxxxx_PUBLISH_PROFILE }}
patelchandni commented 3 months ago

@Julius-Bendt It does not work with dev branch. Latest v1 has all the changes now.