search

Azure / functions-container-action

Enable GitHub developers to deploy to Azure Function Apps Containers using GitHub Actions
MIT License
26 stars 14 forks source link

Future Enhancements #31

Closed patelchandni closed 2 years ago

patelchandni commented 2 years ago
  1. Add support to use "publish profile" auth
  2. Deployment center in Azure to use functions-container-action
patelchandni commented 2 years ago

Essentially, it is using this utility to deploy the app image: https://github.com/microsoft/pipelines-appservice-lib/blob/6299870403febc525eb38b2a1a85fdb5602e9a95/src/RestUtilities/ContainerDeploymentUtility.ts#L15

Therefore, it needs RBAC credentials to update app setting linuxFxVersion/windowsFxVersion with image name.

aaronamm commented 1 year ago

@patelchandni for it needs RBAC credentials to update app setting linuxFxVersion/windowsFxVersion with image name, does this mean we can't add publish-profile option to functions-container-action?

Can we apply implementation from azure/webapps-deploy which has publish-profile option? I think this option is still useful for those who don't have permission to generate RBAC credentials.

Thank you so much.