Azure / go-amqp

AMQP 1.0 client library for Go.
https://github.com/Azure/go-amqp
MIT License
110 stars 58 forks source link

Should Drain API be removed for now #255

Closed jhendrixMSFT closed 1 year ago

jhendrixMSFT commented 1 year ago

The current implementation assumes that the peer will send and acknowledging flow frame when we've sent a drain request. The spec doesn't appear to require this, and while SB does in some cases, we've also seen it take several seconds for the reply to show up. This causes the Drain() API to be a bit flakey. In addition, ActiveMQ doesn't appear to send an ack, making this API broken for that broker.

It can always be added later as required.

richardpark-msft commented 1 year ago

It'd be good, as we get into more of these "implicit RPC" type things to think about how that'd be represented.