search

Azure / go-amqp

AMQP 1.0 client library for Go.
https://github.com/Azure/go-amqp
MIT License
104 stars 56 forks source link

Default message priority should be 4, not 0 #313

Open mkuratczyk opened 8 months ago

mkuratczyk commented 8 months ago

According to the specification, the default priority should be 4: https://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-messaging-v1.0-os.html#type-header It's also mentioned in a comment: https://github.com/Azure/go-amqp/blob/main/message.go#L306

However, currently, it is implicitly set to 0, since that's the default for uint8. For example, I believe this test should pass after removing Priority: 4 but it fails.

Similar issue in AMQP.Net Lite from a few years ago: https://github.com/Azure/amqpnetlite/issues/301