search

Azure / go-amqp

AMQP 1.0 client library for Go.
https://github.com/Azure/go-amqp
MIT License
110 stars 58 forks source link

Can Receiver.unsettledMessages be a count? #317

Closed jhendrixMSFT closed 10 months ago

jhendrixMSFT commented 10 months ago

We had an issue where cross-receiver message settlement caused a memory leak as entries in the unsettledMessages map weren't deleted. While this has been fixed, it brings up the question of whether unsettledMessages really needs to be a map or just an atomically accessed count.

jhendrixMSFT commented 10 months ago

While we can switch to using a count, it would prevent us from properly implementing suspend/resume links.