search

Azure / go-ntlmssp

NTLM/Negotiate authentication over HTTP
MIT License
189 stars 67 forks source link

Update negotiator.go #24

Closed mszuyev closed 5 years ago

mszuyev commented 5 years ago

I've experienced the problem when non-nil err from rt.RoundTrip(req) didn't affect the result and this method returned pair nil, nil instead of nil, err.

mszuyev commented 5 years ago

Probably because of this error redeclaring in the same "if" block u, p, err := reqauth.GetBasicCreds()

SwampDragons commented 5 years ago

I believe this will also solve https://github.com/hashicorp/packer/issues/8229 and a handful of other issues we've had opened over the years.

SwampDragons commented 5 years ago

Thanks @paulmey you rock!