search

Azure / go-ntlmssp

NTLM/Negotiate authentication over HTTP
MIT License
189 stars 67 forks source link

Commit e74ac06fd1c03 introduces breaking changes #33

Open iamcaje-psh opened 2 years ago

iamcaje-psh commented 2 years ago

Parameters were added to functions, breaking downstream dependencies. eg:

.../go/pkg/mod/github.com/go-ldap/ldap/v3@v3.4.3/bind.go:500:96: not enough arguments in call to ntlmssp.ProcessChallenge

speatzle commented 2 years ago

This just broke my builds. I made an issue on https://github.com/go-ldap/ldap/issues/381

iamcaje-psh commented 2 years ago

I had to downgrade to :

go get github.com/Azure/go-ntlmssp@v0.0.0-20211209120228-48547f28849e

to get my project to build. Added a comment to my go.mod letting me know not to upgrade:

require (
    // this version works - newer commits have breaking changes - do not update
    // github.com/Azure/go-ntlmssp v0.0.0-20211209120228-48547f28849e // indirect
    github.com/Azure/go-ntlmssp v0.0.0-20211209120228-48547f28849e // indirect
...
)
opoplawski commented 1 year ago

Given that there are no releases for this project (yet), is there any expectation of API stability? Or is this just a heads up to users?

speatzle commented 1 year ago

Since this broke other projects that depend on this it would be nice to have tagged releases or at least tag a 0.x.x version before breaking api.