Handle http redirect - Githubissues

Azure / go-ntlmssp

NTLM/Negotiate authentication over HTTP

MIT License

189 stars 67 forks source link

Handle http redirect #4

Closed nqv closed 8 years ago

nqv commented 8 years ago

Fixed panic if req.Body is nil or basicAuth is not set
Switched over to http.DefaultTransport if RoundTripper is not provided

Closes #2, #3

nqv commented 8 years ago

^ That travis error: cannot find package "golang.org/x/tools/cmd/vet

boumenot commented 8 years ago

Thanks for the contributing! Unfortunately, there are no tests to validate this change, so I have to verify it in the repository that it is used in (packer-azure.) I'll apply the patch, and see if it works. I'll report back.

I'll take a look at the go vet issue too, that's odd.

nqv commented 8 years ago

Fair enough, I tempted to add tests not have enough knowledge to implement a mock server.

boumenot commented 8 years ago

This is on us. :frowning: It works for packer-azure. Thanks again!