Azure / ibex-dashboard

Custom Analytics Dashboard for Microsoft Bot Framework and other applications as well
http://aka.ms/ibex
MIT License
169 stars 188 forks source link

CSharp Telemetry Plugin Sample Broken Link #177

Closed garypretty closed 7 years ago

garypretty commented 7 years ago

Hi. I want to add the additional telemetry for CSharp in terms of intents and sentiment, but the link to the sample seems to be locked down. https://trpp24botsamples.visualstudio.com/_git/Code?path=%2FCSharp%2Fsample-Telemetry&version=GBmaster&_a=contents

Can you point me to the sample on an alternate link?

morsh commented 7 years ago

Hi gary, sorry for the late reply.

this should either be opened or migrated to github. I'll check and let you know.

deadlyfingers commented 7 years ago

@garypretty we have cloned the sample project into public repo for you - https://github.com/CatalystCode/bot-sample-telemetry

deadlyfingers commented 7 years ago

Once this c# sample is tested with Ibex dashboard we should add the link to the readme to close this issue...

garypretty commented 7 years ago

Thanks. I am testing this now. Should I expect to see a delay in the intent and conversation data being populated in the dashboard? I can see channel hits from the last 2 hours, but no intent / conversation data is showing yet - however, I can see the custom metrics logged in the app insights portal.

morsh commented 7 years ago

@itye-msft - can you check this? I think there might be some updates in the schema that weren't included in the C# code.

garypretty commented 7 years ago

Hi @morsh @itye-msft Just checking to see if there is any update on this? Released my bot yesterday which uses LUIS pretty heavily so would be great to get more telemetry into the portal.

itye-msft commented 7 years ago

Hi @garypretty , The C# client is still undergoing some changes and refactoring in order to be aligned with recent changes we made to the Ibex Dashboard. Nevertheless it shouldn't take long to release it. I'll keep you posted.

Thanks,

morsh commented 7 years ago

@garypretty - this is the updated repo for this issue: https://github.com/CatalystCode/botbuilder-instrumentation-cs

@itye-msft - is there anything more we can share?

garypretty commented 7 years ago

@morsh @deadlyfingers Thanks for this. I am now seeing intent information through the dashboard, which is great. However, I am not seeing any conversation data (i.e. the actual messages). In the previous sample you needed to initialize the telemetry logger to do this, but that doesn’t seem to appear in the readme any more. Any idea why I am not seeing individual messages?

I don't know if this helps, but I am not currently setting the optional text analytics keys for sentiment analysis. Could this be preventing the logging of the conversations?

itye-msft commented 7 years ago

Hi @garypretty The BotBuilder Instrumentation contains only the source code for a DLL to use. The binary can be obtained from nuget as well: PM> Install-Package BotBuilder.Instrumentation Once instantiated, the library will automatically send conversation data to the telemetry. All the data will be visible on the Ibex dashboard automatically.

If you want to see a working bot sample which utilizes the BotBuilder.Instrumentation library please refer to: https://github.com/itye-msft/Bot-with-instrumentation-cs

garypretty commented 7 years ago

@itye-msft Thanks for the reply. I've looked at the sample and I seem to be doing things right. i.e. I am using the new Instrumented LUIS Dialog and I am seeing the right message counts / intents in the portal, but I am not able to see the actual messages sent back & forth between the bot and the user in the conversations area in the top right of the dashboard. Do I need to do something additional to enable this / see the conversations in the dashboard?

I know that previously you were using an ActivityLogger middleware to track messages, but in the AlarmBot sample that doesn't seem to be the case. The Initalize method used to be called from within Global.ascx.cs but I don't see that used anywhere now.

itye-msft commented 7 years ago

@garypretty Internally BotFrameworkApplicationInsightsInstrumentation starts the monitoring automatically in the constructor by hooking into all conversations using ActivityLogger.

We basically encapsulate this to simplify the usage, and it sends all conversations to the telemetry automatically.

Try to click on intents graph as it also shows conversations per intent. I will also need to know what dashboard template were you using (it shows in the title).

Please let me know if that helps.

garypretty commented 7 years ago

Thanks. I will check the intents graph. I am using the Bot Framework Instrumentation Template as far as I know.

garypretty commented 7 years ago

Hi again. Ok, I checked the intents graph and I am seeing conversations! Sorry, just didn't know you would see them there. So, the only thing left right now is the top right hand corner of the dashboard seems to be broken, where I had assumed you could click through to conversations. See the attached file.

2017-07-11_14-53-43

morsh commented 7 years ago

Hi @garypretty - that's the least used feature. @itye-msft LMK if this should work - Basically, you need to use startTransaction/endTransaction and the control the conversion rate (not conversations). That can potentially be used to understand customer converstion statistics.

garypretty commented 7 years ago

@morsh @itye-msft Got it - my bad, because it had cut off I had misread it as conversations!

Ok, great. So it looks like I have this working now. I have noticed another couple of things which don't seem to be right. I am happy to close this issue and raise them as separate issues / changes if you agree that they are currently known issues?

Hopefully these are things I can help with once I am up to speed on the code! Thanks again for your help!

morsh commented 7 years ago

@garypretty - Closing and opening would be awesome.

And if you can help with issues, please do! we can use any help you can give :)

morsh commented 7 years ago

Closing issue, since this is no longer a direct issue.