search

Azure / iot-edge-opc-proxy

OPC Proxy Module
34 stars 19 forks source link

Thread-safe epoll, port range exclusion, and valgrind fixes. #46

Closed marcschier closed 7 years ago

marcschier commented 7 years ago
msftclas commented 7 years ago

@marcschier, Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA. Thanks, Microsoft Pull Request Bot

marcschier commented 7 years ago

This addresses #43 #27, #39

JuergenKosel commented 7 years ago

Hello,

I do not know how to use the port range restriction. I have started the proxyd with the following options: proxyd -D myFilename --version --restricted-ports=4840

And then tried to connect to an OPC UA server listening at the standard port 4840. Which didn't work.

So are the restricted ports a blacklist, so that I have to use the following options, to allow only port 4840: proxyd -D myFilename --version --restricted-ports="1-4839;4841-65535" ?

Greetings Juergen

marcschier commented 7 years ago

Yes, the intention is that it is a blacklist. Maybe the name should be --blacklisted-ports?

marcschier commented 7 years ago

The help is incomprehensible I have to admit. It even mentions -P. I will update this. Let me know if you have a better name for the flag and I will update it.

JuergenKosel commented 7 years ago

I think --blacklisted-ports or --blocked-ports would be more clear.