Azure / iot-edge-v1

Azure IoT Edge

http://azure.github.io/iot-edge/

Other

524 stars 258 forks source link

Added Message ContentEncoding and ContentType #606

Closed sebader closed 6 years ago

sebader commented 6 years ago

Required properties to enable routing on those messages with body content

Description of the problem

Constructed message does not contain ContentType and ContentEncoding. Hence conditional message routing based on message body content is not possible in IoT (Edge) Hub

Description of the solution

Just added the two missing properties to the message header

dariuszparys commented 6 years ago

@varunpuranik PR is good for me, there is just the caveat that this repo isn't building microsoft/azureiotedge-simulated-temperature-sensor:1.0-preview where the actual problem happens when running the docs tutorials. Can we make this repo the building base for the deployed container?

/cc @damonbarry @chipalost

varunpuranik commented 6 years ago

Yes, the PR looks good. And you are right, the image from docker hub is not built from here. We will update our process to make this repo the base for that image. Meanwhile, I will make the same changes in our repo. But that image will get deployed only in our next refresh - sometime in the coming few weeks.