search

Azure / iot-edge-virtual-kubelet-provider

Kubernetes virtual kubelet provider for managing Azure IoT Edge deployments
MIT License
94 stars 25 forks source link

Container image update to GA versions #19

Closed neumanndaniel closed 6 years ago

neumanndaniel commented 6 years ago

Updated the container image references to the GA versions. Referencing to the following issue https://github.com/Azure/iot-edge-virtual-kubelet-provider/issues/18

So, after merging this PR, there must be a new container build and push for microsoft/iot-edge-vk-provider to roll-out the changes.

Container registry credential is not solved with the PR only the incompatible container images for IoT Edge GA.

msftclas commented 6 years ago

CLA assistant check
All CLA requirements met.

neumanndaniel commented 6 years ago

Just added additional parts to support specifying the credentials for a private container registry and providing it through a ConfigMap for the Edge Agent (edgeagent).

veyalla commented 6 years ago

Thanks @neumanndaniel

@avranju PTAL

neumanndaniel commented 6 years ago

Implementing fix for https://github.com/Azure/iot-edge-v1/issues/475#issuecomment-403915333

There for we need to be able to specify environment variables for the edgeHub module.

So, I just updated the current pull request to implement this.

veyalla commented 6 years ago

Thanks again @neumanndaniel! I am going to merge this in. We can address cleanup in a subsequent PR.