Azure / iot-hub-device-update

Device Update for IoT Hub agent
MIT License
51 stars 36 forks source link

Add scoped topics, suback response topic before publish #584

Closed jw-msft closed 6 months ago

jw-msft commented 7 months ago
Jerry-GeGarcia commented 6 months ago
  • For 'ainfo_resp' messages, if the Correlation Data matches the 'en,the client should parse the message and update the agentinfo state.

what is 'en? Oh, enrollment.


Refers to: src/extensions/agent_modules/cloud_communication/eg_mqtt_broker_client/src/adu_agent_info_management.c:65 in 4720e51. [](commit_id = 4720e512a20cf4eb0d01d8f7f504bbe837449c27, deletion_comment = False)

Jerry-GeGarcia commented 6 months ago
  • @brief Implements the Device Update agent state store functionality.

I could use another pair of eyes on this


Refers to: src/extensions/agent_modules/shared/state_store/src/agent_state_store.c:3 in 4720e51. [](commit_id = 4720e512a20cf4eb0d01d8f7f504bbe837449c27, deletion_comment = False)

jw-msft commented 6 months ago
  • For 'ainfo_resp' messages, if the Correlation Data matches the 'en,the client should parse the message and update the agentinfo state.

what is 'en? Oh, enrollment.

Refers to: src/extensions/agent_modules/cloud_communication/eg_mqtt_broker_client/src/adu_agent_info_management.c:65 in 4720e51. [](commit_id = 4720e51, deletion_comment = False)

No actually it's a serious typo--I think I was trying to say matches, then the client but I was typing way to fast with probably some editor key-seq macros mixed in.

Pushed a fix

jw-msft commented 6 months ago

merged up to top pr stack that was merged to topic