search

Azure / iot-identity-service

Source of the Azure IoT Identity Service and related services.
MIT License
37 stars 46 forks source link

Add no-socket-throttle feature to http-common #438

Closed gordonwang0 closed 2 years ago

gordonwang0 commented 2 years ago

Adds a cargo feature no-socket-throttle to http-common. Enabling this disables socket throttling when serving connections on UNIX sockets.

This is in response to #433. The 1.3.0 update consolidated the server code between iotedge and this repo, and unintentionally introduced this repo's throttling mechanism to the Edge daemon. The Edge daemon does not need to throttle the management socket, as only users in the iotedge group can access the management socket. By default, this prevents modules from calling the management socket.

arsing commented 2 years ago

Do we not want throttling on the workload socket?

gordonwang0 commented 2 years ago

The workload socket is split so that each module now has its own socket. That mitigates the risk of modules making repeated requests and denying service to other modules.