search

Azure / iot-identity-service

Source of the Azure IoT Identity Service and related services.
MIT License
37 stars 46 forks source link

feature/snapping: hostname reading fix on Ubuntu Core #521

Closed alexclewontin closed 1 year ago

alexclewontin commented 1 year ago

This fixes how the snap reads the device's hostname on Ubuntu Core, and should be more robust in general.

alexclewontin commented 1 year ago

Very confused with how github is calculating the diff, the first commit is already merged into feature/snapping

arsing commented 1 year ago

The CAP_OWNER commit is from your own branch, not the commit that was merged into Azure/feature-snapping (check the commit SHAs).

GitHub shows the diff for the PR against the common ancestor with the target branch, not the latest state of the merge target branch. That common ancestor is the parent of the CAP_OWNER commit, so the CAP_OWNER commit also shows in the diff.

If you rebase your fix hostname commit on top of the feature-snapping branch it'll get fixed.

alexclewontin commented 1 year ago

Ah good catch. Done