Azure / iot-identity-service

Source of the Azure IoT Identity Service and related services.
MIT License
37 stars 46 forks source link

Update cargo dependencies #535

Closed gordonwang0 closed 1 year ago

gordonwang0 commented 1 year ago
arsing commented 1 year ago

You should update the dependency versionreqs in Cargo.toml too. eg we depend on an old version of serde-with that continues to pulls in an old version of base64.

arsing commented 1 year ago

So just to be clear, you checked all the other dependency versionreqs and serde-with was the only one that was old?

gordonwang0 commented 1 year ago

Actually, I think I'll revert the serde_with version change. Last time we updated dependencies between major versions, we had some issues due to differences in behavior between major versions. Since 1.4 is supposed to be a stable release, I think we should minimize the amount of changes. (And CG isn't complaining about base64, which is the reason for doing this update.)

Let me know if you disagree.

arsing commented 1 year ago

Oh right, I mixed up this one and #536. Keeping this one on the same major versions is fine. What I wrote applies to the main branch PR only.