Fix issues in MQTT Adapter

abhijitnathwani commented 4 years ago

This PR fixes the issues in MQTT Adapter that were causing failure to build

incorrect json key in header file
changed mqtt port in config file from string to int

ghost commented 4 years ago

All CLA requirements met.

dipannita08 commented 4 years ago

The fix should be made in the following way:

Update Line 130 mqtt_cpp.cpp from: const char* mqttConfigId = json_object_get_string(AdapterComponentConfig, PNP_CONFIG_ADAPTER_MQTT_SUPPORTED_CONFIG); to: const char* mqttConfigId = json_object_get_string(AdapterComponentConfig, PNP_CONFIG_ADAPTER_MQTT_IDENTITY);
- The config file is just a sample so generally is expected to be updated whenever running the bridge with interface components that require specific adapters. Changes in this file don't need to be merged generally. But the change you have made in the config.json file is good to merge, so lets keep this.
- Please re-target your branch to merge into Azure/iot-plug-and-play-bridge:master rather than Azure:master

abhijitnathwani commented 4 years ago

Hi @dipannita08 I have added the changes as sugggested. For point 3 , re-targeting to Azure/iot-plug-and-play-bridge:master I can't find this branch in the dropdown.

dipannita08 commented 4 years ago

@abhijitnathwani I've taken care of the fix I recommended here.. You should be able to close this PR, and pull changes from master in a couple days.

abhijitnathwani commented 4 years ago

Alright thanks @dipannita08

Azure / iot-plug-and-play-bridge

Fix issues in MQTT Adapter #41