Azure / iot-plugandplay-models-tools

Tools to manage the device-models repo
MIT License
13 stars 18 forks source link

Push script skips valid DTMIs #58

Closed rido-min closed 4 years ago

rido-min commented 4 years ago

Migrating Public models from Mesh https://github.com/rido-min/azure-dtdl-repository/pull/7 Validation passed, but after merging the push scripts says:

Skipping dtmi/meshsystems/txs_blereader-1.json. It doesn't appear to be a DTDL document.
Skipping dtmi/meshsystems/txs_cellular-1.json. It doesn't appear to be a DTDL document.
Skipping dtmi/meshsystems/txs_cellular-2.json. It doesn't appear to be a DTDL document.
Skipping dtmi/meshsystems/txs_cellular-3.json. It doesn't appear to be a DTDL document.
Skipping dtmi/meshsystems/txs_location-1.json. It doesn't appear to be a DTDL document.

https://github.com/rido-min/azure-dtdl-repository/runs/1197467000?check_suite_focus=true#step:4:13

wondering if the push script should fail if there are json files under dtmi that cannot be uploaded. Without detailed inspection this issue would be difficult to detect.

montgomp commented 4 years ago

Updated regex