Add device model HD08T30MMC

htweijing commented 1 year ago

Thank you for contributing to the IoT Plug and Play Models repository

:memo: Please review this checklist before submission

[x] :eyes: The models submitted in this PR follow the DTDL Naming Guidelines for contributing to this repository.
[x] 🕵️I have validated the models locally using the dmr-client command line tool.
[x] ❗ I understand once the PR is approved, the models are considered immutable: any edits will require to submit new files.
[x] ✨ When creating a new top level dtmi:namespace, I have completed the PR Info Template below.

:zap: PR validation steps are described in the tools Wiki.

PR Info Template

When submitting models to the repository we ask that you provide as much of the following meta information around your models and related devices as possible. This info will be used to improve the IoT Plug and Play ecosystem.

👇: Please replace the markdown comment examples with your own values.

Company Info

Company name: Hatteland Technology AS
Company website: www.hattelandtechnology.com

IoT Plug and Play Device Info

Product website: https://www.hattelandtechnology.com/view_product?id=280!main_category=Marine%20&%20Offshore=
OS & Arch: Windows IoT Enterprise

Model Submission Goals

Device certification: Trusted platform module

Code Owners & Reserved Names

Indicates GitHub alias entries to be added to the repo CODEOWNERS for the incoming model namespace. The codeowner is expected to be involved in subsequent DTDL model submissions against the same namespace.

This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact opencode@microsoft.com with any additional questions or comments.

htweijing commented 1 year ago

@microsoft-github-policy-service agree company="Hatteland Technology AS"

htweijing commented 1 year ago

We are create them as placeholder for extending with own customized DMI table properties in future. Several displayNames will be re-phrased.

Kind Regards

Wei Jing

From: Rido @.> Sent: Wednesday, February 22, 2023 4:17 PM To: Azure/iot-plugandplay-models @.> Cc: Wei Jing @.>; Mention @.> Subject: Re: [Azure/iot-plugandplay-models] Add device model HD08T30MMC (PR #526)

You don't often get email from @.**@.>. Learn why this is importanthttps://aka.ms/LearnAboutSenderIdentification EXTERNAL

@rido-min commented on this pull request.

any reason to publish a copy of LinuxDeviceInfo instead of reusing the existing one? https://github.com/Azure/iot-plugandplay-models/blob/main/dtmi/synnex/linuxdeviceinfo-1.json

same for windowsdeviceinfo

— Reply to this email directly, view it on GitHubhttps://github.com/Azure/iot-plugandplay-models/pull/526#pullrequestreview-1309483574, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A6AQZJ6KVJ6K6ZUX2ELLBELWYYUVXANCNFSM6AAAAAAVD7GHQM. You are receiving this because you were mentioned.Message ID: @.**@.>>

rido-min commented 1 year ago

Keep in mind this repo does not allow edits on accepted models, so these cannot be used as a placeholder. I'd suggest to make the edits to the descriptions and DMI table in this PR.

htweijing commented 1 year ago

I have update the linuxdeviceinfo-1.json and windowsdeviceinfo-1.json with customized fields.

htweijing commented 1 year ago

@rido-min A followup question: When can this model be populated in https://devicemodels.azure.com ? Checked yesterday, it seems to be not listed there.

rido-min commented 1 year ago

thanks for pointing this out !! we had an issue in the publishing pipeline, the model is available now in https://devicemodels.azure.com/dtmi/hattelandtechnology/hd08t30mmc-1.json

Azure / iot-plugandplay-models