Azure / iot-ux-fluent-controls

A collection of shared react UI components used across IoT teams.
MIT License
13 stars 19 forks source link

Fix icon sizing to actually constraint icons #182

Closed PatoBeltran closed 4 years ago

PatoBeltran commented 4 years ago

Icons sizes where being set on the .icon-${size} .icon-${size}:before, since we don't have any nested icon-${size} elements in our DOM it was (since always) being ignore, this made every icon just constraint to the size of the icon symbol itself (in most cases around 14 pixels height and auto width).

With this change the icons will actually take our sizes into account.

This PR also cleans up the icon component and wrapps it in a memo.