search

Azure / iot-ux-fluent-controls

A collection of shared react UI components used across IoT teams.
MIT License
13 stars 19 forks source link

remove role for text input of date-picker #63

Closed dan-lai closed 5 years ago

dan-lai commented 5 years ago

In DatePicker, the button that triggers the calendar pop up has attribute aria-expanded. The text input does not trigger the pop up and is not very reasonable to have aria-expanded attribute although the bug says it should be fixed that way. The solution here removes combobox role for text input since the button and the text input are siblings in element level and it make more sense to me not to assign a combobox role for the text input.

Related task item: https://msazure.visualstudio.com/One/_workitems/edit/3858806

dan-lai commented 5 years ago

In DatePicker, the button that triggers the calendar pop up has attribute aria-expanded. The text input does not trigger the pop up and is not very reasonable to have aria-expanded attribute although the bug says it should be fixed that way. The solution here removes combobox role for text input since the button and the text input are siblings in element level and it make more sense to me not to assign a combobox role for the text input.

Related task item: https://msazure.visualstudio.com/One/_workitems/edit/3858806