Azure / iotedge-lorawan-starterkit

Sample implementation of LoRaWAN components to connect LoRaWAN antenna gateway running IoT Edge directly with Azure IoT.
https://azure.github.io/iotedge-lorawan-starterkit/2.2.1
Other
184 stars 61 forks source link

Deployment is not idempotent when the deployDevice parameter is enabled #2061

Closed hocinehacherouf closed 1 year ago

hocinehacherouf commented 1 year ago

Expected Behavior

When the deployDevice parameter is set to true, the deployment of iotedge-lorawan-starterkit must be idempotent. Each deployment (with the deployDevice parameter equal to true) should:

Current Behavior

With the deployDevice parameter set to true

https://github.com/Azure/iotedge-lorawan-starterkit/blob/267d00cb8861dec87c504f06b3874330322f6011/TemplateBicep/devices.bicep#L31-L33

The output error message:

{
    "status": "failed",
    "error": {
        "code": "DeploymentScriptError",
        "message": "The provided script failed without returning any errors. Please refer to https://aka.ms/DeploymentScriptsTroubleshoot for more deployment script information."
    }
}

Steps to Reproduce

  1. Go to Quick Start guide and press the 'Deploy to Azure' button.
  2. In the 'Custom Deployment' page that opens
    • Fill out all required fields
    • Choose 'true' in the 'Deploy Device' dropdown.
  3. Review + Create the deployment.
  4. Wait until the end of the deployment
  5. Create a new deployment with the same parameters
Mandur commented 1 year ago

Good point, we will provide a fix