Fix problems with snap release - Githubissues

Azure / iotedge

The IoT Edge OSS project

MIT License

1.45k stars 457 forks source link

Fix problems with snap release #7237

Closed damonbarry closed 4 months ago

damonbarry commented 4 months ago

The change fixes a few problems with the snap builds and release:

Snaps weren't built with SNAPCRAFT_BUILD_INFO enabled, so they didn't generate SBOM info. I added the flag to snap builds. Note this isn't a problem for the azure-iot-identity snap because it's built using the snap action in our GitHub workflow, which automatically adds this option.
Snaps were published to the edge channel in the release build. This was intentional the first time, but we want to publish directly to the stable channel from now on.

To test, I ran the CI build pipeline and verified that the snaps have an SBOM.

Azure IoT Edge PR checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines and Best Practices

[X] I have read the contribution guidelines.
[X] Title of the pull request is clear and informative.
[X] Description of the pull request includes a concise summary of the enhancement or bug fix.

Testing Guidelines

[X] Pull request includes test coverage for the included changes.
Description of the pull request includes
- [X] concise summary of tests added/modified
- [X] local testing done.