Azure / iotedge

The IoT Edge OSS project
MIT License
1.45k stars 457 forks source link

Fix problems with edgelet packages release #7285

Closed damonbarry closed 1 month ago

damonbarry commented 2 months ago

I had some problems with the most recent edgelet packages release, and ended up having to update the GitHub release page manually. These changes fix the problems I encountered, as well as follow-on problems I discovered during testing:

builds/misc/packages-release.yaml:

scripts/linux/github/updateLatestVersion.sh:

scripts/linux/publishReleasePackages.sh:

scripts/linux/release-tools.sh:

To test, I set up a separate pipeline in a test environment (forks of Azure/iotedge, Azure/azure-iotedge, and Azure/iot-identity-service, separate key vault, service connections, etc. I commented out the PublishPackagesMicrosoft stage since I don't know how to easily run it in a test environment, but that stage worked fine in the last release anyway, and this change doesn't really mess with it. I confirmed that the release pipeline:

  1. Builds edgelet for all architectures
  2. Updates product-versions.json in the product repo Azure/azure-iotedge), commits the result, and tags it with the version number
  3. Creates a GitHub Release page in the product repo and uploads all the right assets

Azure IoT Edge PR checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines and Best Practices

Testing Guidelines

Draft PRs

Note: We use the kodiakhq bot to merge PRs once the necessary checks and approvals are in place. When it merges a PR, kodiakhq converts the PR title to the commit title, PR description to the commit description, and squashes all the commits in the PR to a single commit. The net effect is that entire PR becomes a single commit. Please follow the best practices mentioned here for the PR title and description

damonbarry commented 1 month ago

/azp run

azure-pipelines[bot] commented 1 month ago
Azure Pipelines successfully started running 4 pipeline(s).