From syncing with SDK team in regards to how disposal of SDK client is supposed to work, we need to make sure we call closeAsync and dispose. Relying on just dispose may not correctly clean up resources in all cases.
Azure IoT Edge PR checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
[ x ] Title of the pull request is clear and informative.
[ x ] Description of the pull request includes a concise summary of the enhancement or bug fix.
Testing Guidelines
[ ] Pull request includes test coverage for the included changes.
Description of the pull request includes
[ ] concise summary of tests added/modified
[ ] local testing done.
Draft PRs
Open the PR in Draft mode if it is:
Work in progress or not intended to be merged.
Encountering multiple pipeline failures and working on fixes.
Note: We use the kodiakhq bot to merge PRs once the necessary checks and approvals are in place. When it merges a PR, kodiakhq converts the PR title to the commit title, PR description to the commit description, and squashes all the commits in the PR to a single commit. The net effect is that entire PR becomes a single commit. Please follow the best practices mentioned here for the PR title and description
From syncing with SDK team in regards to how disposal of SDK client is supposed to work, we need to make sure we call closeAsync and dispose. Relying on just dispose may not correctly clean up resources in all cases.
Azure IoT Edge PR checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines and Best Practices
Testing Guidelines
Draft PRs
Draftmode if it is:Note: We use the kodiakhq bot to merge PRs once the necessary checks and approvals are in place. When it merges a PR, kodiakhq converts the PR title to the commit title, PR description to the commit description, and squashes all the commits in the PR to a single commit. The net effect is that entire PR becomes a single commit. Please follow the best practices mentioned here for the PR title and description