Add command to add layered deployments to IoT Hub

Azure / iotedgedev

The Azure IoT Edge Dev Tool greatly simplifies your Azure IoT Edge development process. It has everything you need to get started and helps with your day-to-day Edge development.

https://aka.ms/iotedgedev

Other

160 stars 70 forks source link

Add command to add layered deployments to IoT Hub #498

Closed EliiseS closed 3 years ago

EliiseS commented 3 years ago

iotedgedev Pull Request Checklist

[ ] Versions updated (both init.py files, CHANGELOG, setup.py, setup.cfg)
[ ] Unit tests pass locally
[ ] Quickstart steps locally validated
[ ] Passes unit tests in CICD pipeline (green on Github pipeline)
[ ] Pypi RC version passes Edge CICD pipeline validation for cross-tool validation

Additional comments

Azure CLI command used: https://docs.microsoft.com/en-us/cli/azure/iot/edge/deployment?view=azure-cli-latest

Closes #430

marianan commented 3 years ago

The main documentation for iotedgedev is under https://github.com/Azure/iotedgedev/wiki/. Some is out of date so pelase don't worry about changing everything that is outdated, however, please include the new command at the command list section

EliiseS commented 3 years ago

@marianan I've add all the cases now, with the exception of the test to verify that the --layered flag is not needed when using the Az CLI. That's because Az CLI does not return the 'deployment type' when querying with az iot edge deployment list/show.

However in the below image you can see the deployments made with the tests are counted as layered despite not having the --layered flag

marianan commented 3 years ago

          default=envvars.get_envvar("LAYERED_DEPLOYMENT_TARGET_CONDITION"),

what is the reason for removing the default value as the env variable value? #Resolved

Refers to: iotedgedev/cli.py:273 in 7b37171. [](commit_id = 7b371710fbcfaee19624af3749860e38a22dbcc8, deletion_comment = True)