Azure / iotedgehubdev

IoT Edge Hub Dev Tool
Other
88 stars 31 forks source link

simulator start fails on windows if username has space in it #398

Open dogoth opened 2 years ago

dogoth commented 2 years ago

VSCode Version: 1.71.1 OS Version: Win 11 Pro Extension Version: 1.25.9

Steps to Reproduce:

  1. when installing windows, choose pick a username that has a space in it. eg "John Smith"
  2. install Visual Studio Code, Azure IoT Tools
  3. start a nodejs iot edge solution (not sure if language choice here is significant)
  4. create module, use "Build and Run IoT Edge Solution in Simulator" feature

error message: " ERROR: Error while executing command: docker-compose -f C:\Users\John Smith\AppData\Local.iotedgehubdev\data\data\docker-compose.yml down. Command '['docker-compose', '-f', 'C:\Users\John', 'Smith\AppData\Local.iotedgehubdev\data\data\docker-compose.yml', 'down']' returned non-zero exit status 1. "

further down an extra clue " "No such command: Smith\AppData\Local.iotedgehubdev\data\data\docker_compose.yml" "

this suggests that the issue is the space during filename declaration to the command for docker-compose, the space maknig it treat the second half as a argument

looks to be issue here: https://github.com/Azure/iotedgehubdev/blob/d3bffb36c71041b636a1093514d960ceda9168b4/iotedgehubdev/edgemanager.py#L70

the argument to -f needs to be in quotes

konichi3 commented 1 year ago

Thanks for reporting. We are adding to the backlog

konichi3 commented 1 year ago

Simulator is in maintenance mode at this time.

Does the solution work on either real device or EFLOW without issues?