Azure / k8s-deploy

GitHub Action for deploying to Kubernetes clusters
MIT License
255 stars 104 forks source link

Feature Request: CroJobs #243

Open juzerali opened 2 years ago

juzerali commented 2 years ago

Feature request

Requesting support for CronJobs. Currently image substitution in CronJobs does not work.

  deploy:
    name: Deploy
    needs: [ build, publish ]
    runs-on: ubuntu-latest
    steps:
      - name: Set the Kubernetes context
        uses: azure/k8s-set-context@v2
        with:
          method: service-account
          k8s-url: https://my-kube-domain
          k8s-secret: ${{ secrets.KUBERNETES_SECRET }}

      - name: Checkout source code
        uses: actions/checkout@v3

      - name: Deploy to the Kubernetes cluster
        uses: azure/k8s-deploy@v1
        with:
          namespace: default
          manifests: |
            kube/cronjob.yml
          images: |
            asia-south1-docker.pkg.dev/project/repo/image:${{ github.sha }}

Expected: CronJob is updated with the new image as per ${{ github.sha }} Actual: Image name that is hardcoded, gets updated

OliverMKing commented 2 years ago

I'm going to look into this!

OliverMKing commented 2 years ago

You can temporarily use https://github.com/Azure/k8s-artifact-substitute this action to swap images prior to running deploy. It should correctly handle this case. Simply take the output of this action and use that as your manifests input in deploy.

github-actions[bot] commented 2 years ago

This issue is idle because it has been open for 14 days with no activity.