Azure / k8s-deploy

GitHub Action for deploying to Kubernetes clusters
MIT License
252 stars 103 forks source link

Feature Request: support re-deploy k8s job. #285

Open victorchen2022 opened 1 year ago

victorchen2022 commented 1 year ago

Feature request

I hope k8s-deploy action can support k8s job deploy repeatedly. because in normal situation, github actions will report error because of k8s job is immuteable so that we have to delete it first.

OliverMKing commented 1 year ago

Can you provide the error that k8s-deploy gives when running repeatedly? k8s-deploy internally uses kubectl apply so it should be idempotent.

victorchen2022 commented 1 year ago

it's just like what https://stackoverflow.com/questions/56264165/field-is-immutable-k8s describe.

On Fri, May 12, 2023 at 1:28 AM Oliver King @.***> wrote:

Can you provide the error that k8s-deploy gives when running repeatedly?

— Reply to this email directly, view it on GitHub https://github.com/Azure/k8s-deploy/issues/285#issuecomment-1544402441, or unsubscribe https://github.com/notifications/unsubscribe-auth/AV7MPKFG5EYQFDGCW6V7A7TXFUOU7ANCNFSM6AAAAAAX4MPMTU . You are receiving this because you authored the thread.Message ID: @.***>

OliverMKing commented 1 year ago

it's just like what https://stackoverflow.com/questions/56264165/field-is-immutable-k8s describe. On Fri, May 12, 2023 at 1:28 AM Oliver King @.> wrote: Can you provide the error that k8s-deploy gives when running repeatedly? — Reply to this email directly, view it on GitHub <#285 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AV7MPKFG5EYQFDGCW6V7A7TXFUOU7ANCNFSM6AAAAAAX4MPMTU . You are receiving this because you authored the thread.Message ID: @.>

All k8s tools I'm aware of follow the same approach that k8s-deploy used here. The stackoverflow link's solution is to delete the overlapping deployment. I'm not sure what a good way for k8s-deploy to do that would be. Deleting a resource is an extremely destructive action.

github-actions[bot] commented 1 year ago

This issue is idle because it has been open for 14 days with no activity.