Azure / k8s-deploy

GitHub Action for deploying to Kubernetes clusters
MIT License
252 stars 103 forks source link

Bug: Unable to use the latest release of the GitHub action #300

Closed bramdehart closed 10 months ago

bramdehart commented 10 months ago

What happened?

New version 1.10.0 was released 3 days ago: https://github.com/Azure/k8s-deploy/releases/tag/4.10.0 However, in the GitHub action release page, the new version is not listed: image Yet, the latest tag is visible on when the 'Use latest version' option is selected: image

image

I am unable to resolve the latest version: image Also, unable to retrieve lates release by the following links: https://github.com/marketplace/actions/deploy-to-kubernetes-cluster?version=v10.0 https://github.com/marketplace/actions/deploy-to-kubernetes-cluster?version=10.0 https://github.com/marketplace/actions/deploy-to-kubernetes-cluster?version=latest

Version

Runner

self-hosted

Relevant log output

image

Does is have to do with the new release workflow?: https://github.com/Azure/k8s-deploy/pull/297

davidgamero commented 10 months ago

this appears to be related to an issue with the updated release workflow missing the lib directory, which should be fixed by https://github.com/Azure/action-release-workflows/pull/1

patching now with https://github.com/Azure/k8s-deploy/pull/301

davidgamero commented 10 months ago

release v4.10.0 has been regenerated, and I can see the /lib directory on the tag commit with index.js now, so that should get us back up and running. @bramdehart please let us know when you have a chance to try it out

bramdehart commented 10 months ago

@davidgamero I will try but am mostly sure it still wouldn't work. The version is still not listed in the github action marketplace page. See for exameple

image Were the latest version is also listed as the tag

This is not the case with the k8s-deploy action image

Also you can spot the formatting difference in tagging, with and without 'v' since release refactor.

bramdehart commented 10 months ago

@davidgamero I can confirm that is now works. Still weird that is not listed as seperate tag on the Github Action page on marketplace. Issue resolved :)

davidgamero commented 10 months ago

I see what you mean with the missing tag on the action page. Ill take a look, but Im glad it's working for you now!