search

Azure / k8s-deploy

GitHub Action for deploying to Kubernetes clusters
MIT License
252 stars 103 forks source link

fix: ensure imageNames are not empty strings #303

Closed Foxboron closed 7 months ago

Foxboron commented 10 months ago

In Typescript/Javascript an empty string split on newline is going to produce an array with an empty string.

=> "".split('\n')
[""]

This causes the action to produce a warning, unless pull-images is set to false.

Failed to get dockerfile path for image : Error: The process '/usr/bin/docker' failed with exit code 1

Filtering the list to remove any zero-length strings from the array solves this issue.

Foxboron commented 10 months ago

Note the previously signed CLA is not valid for this code contribution.

github-actions[bot] commented 9 months ago

This PR is idle because it has been open for 14 days with no activity.

davidgamero commented 7 months ago

@Foxboron looks like you need to format with npm run format

Foxboron commented 7 months ago

Done, but I'll reiterate that the green checkmark from the CLA bot is not applicable for this commit.

davidgamero commented 7 months ago

@microsoft-github-policy-service rerun

davidgamero commented 7 months ago

do you mean because of the minimum line/file requirements?

Foxboron commented 7 months ago

Ah, if that is the portion that triggers then that is fine. I thought I had singed it for my personal contributors at some point and can't tell form the check why it was green.

Feel free to merge, thanks :)