Azure / k8s-deploy

GitHub Action for deploying to Kubernetes clusters
MIT License
252 stars 103 forks source link

Bug: pod is not restarted if docker tag name is not changed #318

Open youngkyu-c opened 5 months ago

youngkyu-c commented 5 months ago

What happened?

if the manifest file is deployment, i expected restarting pod. but, pod is not restarted because owner is wrong. it is related with this code block.

    if (result?.stdout) {
         const stdout = result.stdout.split('\n')
         core.debug('stdout from getNewReplicaSet is ' + JSON.stringify(stdout))
         stdout.forEach((line: string) => {
            const newreplicaset = 'newreplicaset'
            if (line && line.toLowerCase().indexOf(newreplicaset) > -1) {
               core.debug(
                  `found string of interest for replicaset, line is ${line}`
               )
               core.debug(
                  `substring is ${line.substring(newreplicaset.length).trim()}`
               )
               newReplicaSet = line
                  .substring(newreplicaset.length)
                  .trim()
                  .split(' ')[0]
            }
         })
      }

here is the result of kubectl describe deployment.

...
NewReplicaSet:   xxx-deployment-7675bf5865 (1/1 replicas created)
...

and this line will be converted to : .

스크린샷 2024-03-27 22 55 19

i think const newreplicaset = 'newreplicaset' should be changed to const newreplicaset = 'newreplicaset:'.

Version

Runner

self hosted

Relevant log output

##[debug]found string of interest for replicaset, line is   Progressing    True    NewReplicaSetAvailable
##[debug]substring is True    NewReplicaSetAvailable
##[debug]found string of interest for replicaset, line is NewReplicaSet:   xxx-deployment-77546558b9 (1/1 replicas created)
##[debug]substring is :   xxx-deployment-77546558b9 (1/1 replicas created)