Azure / k8s-lint

GitHub Action to validate Kubernetes manifest files
MIT License
32 stars 13 forks source link

Migrate from kubeval to kubeconform #46

Closed mostafahussein closed 1 year ago

mostafahussein commented 1 year ago

This PR will achieve the following:

OliverMKing commented 1 year ago

Thanks for this PR! I'll take a look in the next couple of days (I've been pretty busy).

OliverMKing commented 1 year ago

@mostafahussein not sure why the Minikube tests aren't working. You might have to revert the version jump on that action.

jaiveerk commented 1 year ago

@mostafahussein not sure why the Minikube tests aren't working. You might have to revert the version jump on that action.

For context, some of the other actions we maintain use a different setup-minikube action that you may want to try out if you aren't able to get past the failure: https://github.com/Azure/k8s-deploy/blob/main/.github/workflows/run-integration-tests-bluegreen-service.yml#L37

mostafahussein commented 1 year ago

For maintainability, I migrated the pipeline to the same action used in k8s-deploy as suggested by @jaiveerk

github-actions[bot] commented 1 year ago

This PR is idle because it has been open for 14 days with no activity.

mostafahussein commented 1 year ago

@OliverMKing, will you be able to merge this anytime soon?

github-actions[bot] commented 1 year ago

This PR is idle because it has been open for 14 days with no activity.

piroinno commented 1 year ago

@OliverMKing just waiting on you now :-)

davidgamero commented 1 year ago

thanks for this contribution! Before this can merge, you'll have to sign your commits

github-actions[bot] commented 1 year ago

This PR is idle because it has been open for 14 days with no activity.

mostafahussein commented 1 year ago

hello @OliverMKing , @jaiveerk if you have enough time, is it possible to merge this pr?

jaiveerk commented 1 year ago

merged, thanks for this contribution @mostafahussein