search

Azure / k8s-set-context

GitHub Action for setting context and retrieving Kubeconfig before deploying to Kubernetes clusters
MIT License
89 stars 34 forks source link

Feature Request: Created tag for version v4 #85

Closed dimapasko closed 7 months ago

dimapasko commented 8 months ago

Feature request

According to previous version conventions, all major versions had the tag like v4.

This aligns with best practices in version management as outlined in the GitHub documentation.

Therefore, could a tag v4 for version 4.0.0be created?

acrogenesis commented 8 months ago

in the meantime it can be used like this: uses: azure/k8s-set-context@v4.0.0

dimapasko commented 8 months ago

in the meantime it can be used like this: uses: azure/k8s-set-context@v4.0.0

Yeah, sure, but I'd prefer to use azure/k8s-set-context@v4.

odoucet commented 8 months ago

yes please, add "v4".

rofafor commented 7 months ago

The v4 exists now, but points to wrong commit having no build artifacts and therefore resulting an error:

Error: File not found: '/home/runner/_work/_actions/azure/k8s-set-context/v4/lib/index.js'

Edit: It seems that a new issue has been created for this: https://github.com/Azure/k8s-set-context/issues/88

davidgamero commented 7 months ago

thank you for letting us know you value the major version tags!

the v4 tag has been regenerated, and the release workflow has been updated to auto-regenerate it on each new release

davidgamero commented 7 months ago

please feel free to reopen if you continue to encounter any issue with the v4 tag