Azure / karpenter-provider-azure

AKS Karpenter Provider
Apache License 2.0
308 stars 47 forks source link

feat: support setting custom dns-service-ip via --dns-service-ip flag #329

Closed Bryce-Soghigian closed 1 month ago

Bryce-Soghigian commented 2 months ago

Fixes #

Description

How was this change tested?

*

Does this change impact docs?

Release Note

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 9055008659

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/operator/options/options_validation.go 7 10 70.0%
<!-- Total: 28 31 90.32% -->
Files with Coverage Reduction New Missed Lines %
pkg/providers/imagefamily/bootstrap/aksbootstrap.go 2 86.84%
<!-- Total: 2 -->
Totals Coverage Status
Change from base Build 8905676791: -0.007%
Covered Lines: 36294
Relevant Lines: 37123

💛 - Coveralls
Bryce-Soghigian commented 1 month ago

Closing this will reopen in a couple of weeks after I finish the azure cni work