[WIP] feat: drift when the subnet id changes

Azure / karpenter-provider-azure

AKS Karpenter Provider

Apache License 2.0

308 stars 47 forks source link

[WIP] feat: drift when the subnet id changes #334

Closed Bryce-Soghigian closed 1 month ago

Bryce-Soghigian commented 2 months ago

Fixes #

Description This PR Introduces functionality to drift the nodes when the subnet either drifts from the expected subnet. The expected subnet is defined as either the --vnet-subnet-id set on cluster create, or the vnet-subnet-id specified on the AKSNodeClass

How was this change tested?

Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[ ] No

Release Note

Bryce-Soghigian commented 2 months ago

I couldn't see a way to do staging pr to the azure/karpenter-provider-azure repo for staging in some changes from my bsoghigian/subnet-drift -> bsoghigian/vnet-subnet-id so this contains all of the commits. I wanted access to the e2e tests so putting this here.

https://github.com/Azure/karpenter-provider-azure/pull/334/commits/510a39f500f78d83b3a9caaca58565a46406c6ee is the real commit of what has been added.