fix: removing kubelet flag --azure-container-registry-config for 1.30 onwards to fix bootstrap

Bryce-Soghigian commented 4 months ago

Fixes #

Description Bootstrap for 1.30 will fail if we have the --azure-container-registry-config flag specified.

azureuser@aks-general-purpose-78r6l:~$ journalctl -u kubelet.service
---
May 10 08:31:26 aks-general-purpose-78r6l kubelet[10604]: E0510 08:29:13.285779   10604 run.go:74]"command failed" err="failed to parse kubelet flag: unknown flag: --azure-container-registry-config"
May 10 08:31:26 aks-general-purpose-78r6l kubelet[13211]: E0510 08:31:26.037146   13211 run.go:74] "command failed" err="failed to parse kubelet flag: unknown flag: --azure-container-registry-config"
May 10 08:31:26 aks-general-purpose-78r6l systemd[1]: kubelet.service: Main process exited, code=exited, status=1/FAILURE
May 10 08:31:26 aks-general-purpose-78r6l systemd[1]: kubelet.service: Failed with result 'exit-code'.

By removing this flag we get nodes for k8s version 1.30 to bootstrap successfully.

How was this change tested?

make az-all

Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[ ] No

Release Note

coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9212434329

Details

3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage remained the same at 97.774%

Files with Coverage Reduction	New Missed Lines	%
pkg/providers/imagefamily/bootstrap/aksbootstrap.go	2	87.1%
<!--	Total:	2		-->

Totals
Change from base Build 9074172591:	0.0%
Covered Lines:	36282
Relevant Lines:	37108

💛 - Coveralls

Bryce-Soghigian commented 4 months ago

Warning FailedCreatePodSandBox 2m42s kubelet Failed to create pod sandbox: rpc error: code = Unknown desc = failed to setup network for sandbox "": plugin type="cilium-cni" failed (add): failed to invoke delegated plugin ADD for IPAM: http request failed: Post "http://": dial tcp :: connect: connection refused; failed to request IP address from CNS Normal SandboxChanged 98s (x6 over 2m41s) kubelet Pod sandbox changed, it will be killed and re-created. Normal Pulling 44s (x3 over 98s) kubelet Pulling image "/pause:3.6" Warning Failed 44s (x3 over 88s) kubelet Failed to pull image "/pause:3.6": failed to pull and unpack image "/pause:3.6": failed to resolve reference "/pause:3.6": failed to authorize: failed to fetch anonymous token: unexpected status from GET request to https:///oauth2/token?scope=repository%3Apause%3Apull&service=: 401 Unauthorized Warning Failed 44s (x3 over 88s) kubelet Error: ErrImagePull Normal BackOff 20s (x4 over 87s) kubelet Back-off pulling image "/pause:3.6" Warning Failed 20s (x4 over 87s) kubelet Error: ImagePullBackOff

Bryce-Soghigian commented 4 months ago

Messed up the history here, so closing in favor of reopening a new one. Will transfer feedback onto the new one.

Azure / karpenter-provider-azure