Azure / karpenter-provider-azure

AKS Karpenter Provider
Apache License 2.0
376 stars 57 forks source link

fix: reallowing nodeclaim zones to fix node/nodeclaim creations for workloads with zone affinity constraints #340

Closed comtalyst closed 4 months ago

comtalyst commented 4 months ago

Fixes #339

Description See the issue. This change should not undo the continuous drift issue that https://github.com/Azure/karpenter-provider-azure/pull/274 fixes, as adding zones requirements is still prohibited on the nodepool CRD, which is the (intentionally) user-facing interface. Current drift logic also "ignore" requirements that exist in NodeClaims, but not NodePools.

How was this change tested?

Does this change impact docs?

Release Note

- Fix the issue where Karpenter/NAP sometimes cannot create nodes/nodeclaims for workloads with zone affinity constraints
coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9039702148

Details


Totals Coverage Status
Change from base Build 8994810202: 0.0%
Covered Lines: 36279
Relevant Lines: 37105

💛 - Coveralls