Azure / karpenter-provider-azure

AKS Karpenter Provider
Apache License 2.0
308 stars 47 forks source link

fix configure-values.sh missing AZURE_SUBSCRIPTION_ID #342

Open ottodeng opened 1 month ago

ottodeng commented 1 month ago

Fixes #

Description

ottodeng@karpenter-client:~$ chmod +x ./configure-values.sh && ./configure-values.sh ${CLUSTER_NAME} ${RG} karpenter-sa karpentermsi Configuring karpenter-values.yaml for cluster karpenter in resource group karpenter ... Error: variable ${AZURE_SUBSCRIPTION_ID} not set

How was this change tested?

ottodeng@karpenter-client:~$ chmod +x ./configure-values.sh && ./configure-values.sh ${CLUSTER_NAME} ${RG} karpenter-sa karpentermsi Configuring karpenter-values.yaml for cluster karpenter in resource group karpenter ...

*

Does this change impact docs?

Release Note

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 9476339764

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Totals Coverage Status
Change from base Build 9388584261: 0.0%
Covered Lines: 36286
Relevant Lines: 37115

💛 - Coveralls
Bryce-Soghigian commented 1 month ago

triggering tests again and we can get this in.