chore: Migrate to Go's native multierror handling

Azure / karpenter-provider-azure

AKS Karpenter Provider

Apache License 2.0

376 stars 57 forks source link

chore: Migrate to Go's native multierror handling #354

Closed fmuyassarov closed 3 months ago

fmuyassarov commented 4 months ago

Fixes # NA

Description Now that Go supports handling multiple errors directly from version 1.20 onwards, this commit removes the need for an external library and instead uses native methods of multi-error handling.

How was this change tested?

Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

Release Note

fmuyassarov commented 4 months ago

/test

fmuyassarov commented 4 months ago

@Bryce-Soghigian I assume I don't have permission to trigger tests. Would you mind to help with triggering them?

coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9095892720

Details

2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 97.774%

Totals
Change from base Build 9074172591:	0.0%
Covered Lines:	36279
Relevant Lines:	37105

💛 - Coveralls

fmuyassarov commented 4 months ago

ping @Bryce-Soghigian

Bryce-Soghigian commented 3 months ago

Upstream karpenter also uses multierr from uber. Until we see that move over I am thinking it best we stay consistent in the codebase.

Closing for now, but thanks for raising the idea!