Azure / karpenter-provider-azure

AKS Karpenter Provider
Apache License 2.0
376 stars 57 forks source link

refactor: rework aged authentication config interface #366

Closed comtalyst closed 6 days ago

comtalyst commented 4 months ago

Fixes #

Description Part of #224 This involves refactoring of auth config, removing some redundant code (e.g., in favor of DefaultAzureCredentials, remove some unused variables), and renaming ARM_USER_ASSIGNED_IDENTITY_ID to KUBELET_IDENTITY_CLIENT_ID for accuracy to its purpose/use. See core motivations in the issue.

How was this change tested?

Does this change impact docs?

Release Note

- Deprecate `ARM_USE_CREDENTIAL_FROM_ENVIRONMENT` and `ARM_USE_MANAGED_IDENTITY_EXTENSION` in favor of track2-based authentication: https://github.com/Azure/azure-sdk-for-go/blob/main/sdk/azidentity/README.md#defaultazurecredential
- Rename `ARM_USER_ASSIGNED_IDENTITY_ID` to `KUBELET_IDENTITY_CLIENT_ID` for accuracy to its purpose/use
- Remove unused environment variables `AZURE_CLUSTER_NAME` and `ARM_VM_TYPE`
coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 11064404930

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/providers/instance/azure_client.go 0 2 0.0%
pkg/providers/instance/skuclient/skuclient.go 0 5 0.0%
<!-- Total: 36 43 83.72% -->
Files with Coverage Reduction New Missed Lines %
pkg/auth/util.go 2 0.0%
pkg/auth/config.go 4 73.58%
<!-- Total: 6 -->
Totals Coverage Status
Change from base Build 11063867966: 0.2%
Covered Lines: 36249
Relevant Lines: 37027

💛 - Coveralls