test(e2e): validate that pulling from an acr registry attached to aks via --attach-acr with karpenter nodes works

Bryce-Soghigian commented 4 months ago

Fixes #

Description As part of the efforts to fix 1.30 bootstrap we removed a flag that removes functionality for out of tree providers. One of the side affects of this is that ACR Pull will not work in the same way. We needed a way to validate this image pull works in a reproducible and consistent way.

This test suite is that. Currently it has to be ran locally to target specific k8s versions so a nice followup at lower priority would be to add the ability to run our e2es against a specific k8s version. How was this change tested?

make az-e2etests

[251.679 seconds]
------------------------------

Ran 1 of 1 Specs in 251.874 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestAcr (251.87s)
PASS
ok      github.com/Azure/karpenter-provider-azure/test/suites/acr       252.588s

Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[ ] No

Release Note

coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9373575828

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0 changed or added relevant lines in 0 files are covered.
17 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.008%) to 97.766%

Files with Coverage Reduction	New Missed Lines	%
pkg/providers/imagefamily/bootstrap/aksbootstrap.go	17	85.53%
<!--	Total:	17		-->

Totals
Change from base Build 9074172591:	-0.008%
Covered Lines:	36286
Relevant Lines:	37115

💛 - Coveralls

comtalyst commented 4 months ago

I would recommend running it against the failing case (e.g., undoing https://github.com/Azure/karpenter-provider-azure/pull/220) as well to validate it.

Bryce-Soghigian commented 1 month ago

gonna rewrite this on the azure repo rather than my fork.

Azure / karpenter-provider-azure