fix: long running setup for expired auth token track 2 bug

Bryce-Soghigian commented 3 weeks ago

Fixes #

Description The track 2 sdk has a bug for long living tokens(longer than 24hrs) they will not be refreshed properly. This pr adds a thin wrapper around the GetToken() interface method to set the ExpiresOn timestamp to be earlier and force a token refresh earlier.

How was this change tested?

2 long running clusters both on NAP and Self Hosted ran without seeing expired token errors
make presubmit

Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[ ] No

Release Note

coveralls commented 3 weeks ago

Pull Request Test Coverage Report for Build 9421738010

Details

0 of 16 (0.0%) changed or added relevant lines in 2 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.04%) to 97.73%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/providers/instance/azure_client.go	0	3	0.0%
pkg/auth/cred.go	0	13	0.0%
<!--	Total:	0	16	0.0%	-->

Files with Coverage Reduction	New Missed Lines	%
pkg/auth/cred.go	1	44.44%
<!--	Total:	1		-->

Totals
Change from base Build 9388584261:	-0.04%
Covered Lines:	36286
Relevant Lines:	37129

💛 - Coveralls

coveralls commented 3 weeks ago

Pull Request Test Coverage Report for Build 9450969455

Details

0 of 16 (0.0%) changed or added relevant lines in 2 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.04%) to 97.73%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/providers/instance/azure_client.go	0	3	0.0%
pkg/auth/cred.go	0	13	0.0%
<!--	Total:	0	16	0.0%	-->

Files with Coverage Reduction	New Missed Lines	%
pkg/auth/cred.go	1	44.44%
<!--	Total:	1		-->

Totals
Change from base Build 9388584261:	-0.04%
Covered Lines:	36286
Relevant Lines:	37129

💛 - Coveralls

coveralls commented 2 weeks ago

Pull Request Test Coverage Report for Build 9522232903

Details

0 of 14 (0.0%) changed or added relevant lines in 2 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.04%) to 97.73%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/providers/instance/azure_client.go	0	1	0.0%
pkg/auth/cred.go	0	13	0.0%
<!--	Total:	0	14	0.0%	-->

Files with Coverage Reduction	New Missed Lines	%
pkg/auth/cred.go	1	44.44%
<!--	Total:	1		-->

Totals
Change from base Build 9520296180:	-0.04%
Covered Lines:	36286
Relevant Lines:	37129

💛 - Coveralls

coveralls commented 2 weeks ago

Pull Request Test Coverage Report for Build 9590583019

Details

0 of 14 (0.0%) changed or added relevant lines in 2 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.04%) to 97.73%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/providers/instance/azure_client.go	0	1	0.0%
pkg/auth/cred.go	0	13	0.0%
<!--	Total:	0	14	0.0%	-->

Files with Coverage Reduction	New Missed Lines	%
pkg/auth/cred.go	1	44.44%
<!--	Total:	1		-->

Totals
Change from base Build 9587074007:	-0.04%
Covered Lines:	36286
Relevant Lines:	37129

💛 - Coveralls

andyzhangx commented 1 week ago

does this workaround work? @Bryce-Soghigian

Bryce-Soghigian commented 1 week ago

@andyzhangx yes it seems to be working for over a week for me

coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 9669960661

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 14 (0.0%) changed or added relevant lines in 2 files are covered.
7 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.04%) to 97.727%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/providers/instance/azure_client.go	0	1	0.0%
pkg/auth/cred.go	0	13	0.0%
<!--	Total:	0	14	0.0%	-->

Files with Coverage Reduction	New Missed Lines	%
pkg/auth/cred.go	1	44.44%
pkg/providers/instancetype/instancetypes.go	6	88.3%
<!--	Total:	7	-->

Totals
Change from base Build 9587074007:	-0.04%
Covered Lines:	36287
Relevant Lines:	37131

💛 - Coveralls

coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 9670992016

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 14 (0.0%) changed or added relevant lines in 2 files are covered.
7 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.04%) to 97.727%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/providers/instance/azure_client.go	0	1	0.0%
pkg/auth/cred.go	0	13	0.0%
<!--	Total:	0	14	0.0%	-->

Files with Coverage Reduction	New Missed Lines	%
pkg/auth/cred.go	1	44.44%
pkg/providers/instancetype/instancetypes.go	6	88.3%
<!--	Total:	7	-->

Totals
Change from base Build 9587074007:	-0.04%
Covered Lines:	36287
Relevant Lines:	37131

💛 - Coveralls

coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 9700805392

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 20 (0.0%) changed or added relevant lines in 2 files are covered.
7 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.06%) to 97.711%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/providers/instance/azure_client.go	0	1	0.0%
pkg/auth/cred.go	0	19	0.0%
<!--	Total:	0	20	0.0%	-->

Files with Coverage Reduction	New Missed Lines	%
pkg/auth/cred.go	1	38.1%
pkg/providers/instancetype/instancetypes.go	6	88.3%
<!--	Total:	7	-->

Totals
Change from base Build 9587074007:	-0.06%
Covered Lines:	36287
Relevant Lines:	37137

💛 - Coveralls

coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 9701170413

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 22 (0.0%) changed or added relevant lines in 2 files are covered.
7 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.06%) to 97.706%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/providers/instance/azure_client.go	0	1	0.0%
pkg/auth/cred.go	0	21	0.0%
<!--	Total:	0	22	0.0%	-->

Files with Coverage Reduction	New Missed Lines	%
pkg/auth/cred.go	1	36.36%
pkg/providers/instancetype/instancetypes.go	6	88.3%
<!--	Total:	7	-->

Totals
Change from base Build 9587074007:	-0.06%
Covered Lines:	36287
Relevant Lines:	37139

💛 - Coveralls

coveralls commented 6 days ago

Pull Request Test Coverage Report for Build 9718106940

Details

0 of 22 (0.0%) changed or added relevant lines in 2 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.06%) to 97.706%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/providers/instance/azure_client.go	0	1	0.0%
pkg/auth/cred.go	0	21	0.0%
<!--	Total:	0	22	0.0%	-->

Files with Coverage Reduction	New Missed Lines	%
pkg/auth/cred.go	1	36.36%
<!--	Total:	1		-->

Totals
Change from base Build 9717899097:	-0.06%
Covered Lines:	36287
Relevant Lines:	37139

Azure / karpenter-provider-azure