Closed rakechill closed 2 weeks ago
coveralls
commented
2 weeks ago | Totals | |
|---|---|
| Change from base Build 9573708617: | 0.0% |
| Covered Lines: | 36287 |
| Relevant Lines: | 37116 |
coveralls
commented
2 weeks ago | Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| pkg/providers/instancetype/instancetypes.go | 1 | 88.37% | ||
| pkg/cache/unavailableofferings.go | 2 | 95.45% | ||
| <!-- | Total: | 3 | --> |
| Totals | |
|---|---|
| Change from base Build 9573708617: | -0.008% |
| Covered Lines: | 36286 |
| Relevant Lines: | 37118 |
coveralls
commented
2 weeks ago | Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| pkg/providers/instancetype/instancetypes.go | 1 | 88.37% | ||
| pkg/cache/unavailableofferings.go | 2 | 95.45% | ||
| <!-- | Total: | 3 | --> |
| Totals | |
|---|---|
| Change from base Build 9573708617: | -0.008% |
| Covered Lines: | 36286 |
| Relevant Lines: | 37118 |
coveralls
commented
2 weeks ago | Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| pkg/providers/instancetype/instancetypes.go | 1 | 88.37% | ||
| <!-- | Total: | 1 | --> |
| Totals | |
|---|---|
| Change from base Build 9587074007: | -0.002% |
| Covered Lines: | 36288 |
| Relevant Lines: | 37118 |
coveralls
commented
2 weeks ago | Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| pkg/providers/instancetype/instancetypes.go | 1 | 88.37% | ||
| <!-- | Total: | 1 | --> |
| Totals | |
|---|---|
| Change from base Build 9587074007: | -0.002% |
| Covered Lines: | 36288 |
| Relevant Lines: | 37118 |
coveralls
commented
2 weeks ago | Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| pkg/providers/instancetype/instancetypes.go | 1 | 88.3% | ||
| <!-- | Total: | 1 | --> |
| Totals | |
|---|---|
| Change from base Build 9587074007: | -0.002% |
| Covered Lines: | 36287 |
| Relevant Lines: | 37117 |
Description I'm working with the Kaito team to integrate with Karpenter Azure Provider. They noticed that they were unable to use some GPU skus due to "insufficient capacity", but were able to confirm that the capacity was available and that this wasn't happening when provisioning nodes directly using AKS APIs.
It turns out that this was due to a small bug in retrieving availability zones for SKUs. We properly handle the case for non-zonal regions, but do not properly handle non-zonal offerings within zonal regions. I've updated the condition to handle this scenario.
Including Alex's comments wrt these non-zonal instance types here for future reference:
How was this change tested?
Does this change impact docs?
Release Note