Remove key vault read requirement

Azure / kubernetes-keyvault-flexvol

Azure keyvault integration with Kubernetes via a Flex Volume

MIT License

253 stars 83 forks source link

Remove key vault read requirement #128

Closed timja closed 4 years ago

timja commented 4 years ago

Reason for Change: https://github.com/Azure/kubernetes-keyvault-flexvol/issues/78#issuecomment-524011386

Issue Fixed: Fixes https://github.com/Azure/kubernetes-keyvault-flexvol/issues/78

Notes for Reviewers:

timja commented 4 years ago

could you review please @ritazh 😺

timja commented 4 years ago

Thank you for the PR @timja! Just few minor doc/example things where we do want to keep resourcegroup and subscriptionid for backward compatibility. Will remove after v+2. But other than that LGTM.

Done, although I would have thought tags would have been fine for old docs, but up to you. 👍

timja commented 4 years ago

Thanks @ritazh! Would love a release when you have time 😺

ritazh commented 4 years ago

Done. Thanks @timja for your contribution! 🎉