Remove documentation re: requiring Reader perms for SPN on KeyVault

Azure / kubernetes-keyvault-flexvol

Azure keyvault integration with Kubernetes via a Flex Volume

MIT License

253 stars 83 forks source link

Remove documentation re: requiring Reader perms for SPN on KeyVault #147

Closed lee0c closed 4 years ago

lee0c commented 4 years ago

Reason for Change:

Follow up to PR #128 - align documentation to update. Reader perm requirement was removed but docs still reference needing it.

Issue Fixed:

Related to already closed issue #78

Notes for Reviewers: None

ritazh commented 4 years ago

Thanks for the PR @lee0c 🎉 Instead of removing it altogether, can I request that you update the section with Optional if you are using version < v0.0.13. We are currently on v0.0.15 need to support older version at least for a bit longer. Added this issue to track: https://github.com/Azure/kubernetes-keyvault-flexvol/issues/149

lee0c commented 4 years ago

Absolutely, good call out @ritazh . I'll do that now 👍

lee0c commented 4 years ago

@ritazh Wanted to let you know that I updated this per your comment :)