search

Azure / kubernetes-keyvault-flexvol

Azure keyvault integration with Kubernetes via a Flex Volume
MIT License
253 stars 83 forks source link

Support 1.17.0 #168

Closed snodnipper closed 4 years ago

snodnipper commented 4 years ago

Describe the bug When using 1.17.0 AKS I encountered the following error. Returning to 1.15.5 worked fine.

unable to recognize "https://raw.githubusercontent.com/Azure/kubernetes-keyvault-flexvol/master/deployment/kv-flexvol-installer.yaml": no matches for kind "DaemonSet" in version "extensions/v1beta1"

Key Vault FlexVolume version keyvault-flexvolume:v0.0.15

Kubernetes version 1.17.0

aramase commented 4 years ago

@snodnipper The apiVersion extensions/v1beta1 has been deprecated as of 1.16+. We will update the api version in the manifest to apps/v1. Thank you for opening the issue.

ohthehugemanatee commented 4 years ago

also, the spec for a DaemonSet now requires a spec.selector value which matches the metadata for the pod itself. Used to tell which pods were started by this Daemonset. So it should look like

...
apiVersion: apps/v1
kind: DaemonSet
metadata:
  labels:
    app: keyvault-flexvolume
  name: keyvault-flexvolume
  namespace: kv
spec:
  selector:
    matchLabels:
      app: keyvault-flexvolume
  updateStrategy:
    type: RollingUpdate
  template:
...

I would open a PR, but I'm not sure how you deal with backwards compatibility for this kind of breaking change.

ritazh commented 4 years ago

Thanks @ohthehugemanatee! PRs are welcome! 👏 We should move to the new api version as the k8s versions we support should work with newer api versions too.

ohthehugemanatee commented 4 years ago

Thanks for clarifying, here you go!