search

Azure / kubernetes-keyvault-flexvol

Azure keyvault integration with Kubernetes via a Flex Volume
MIT License
253 stars 83 forks source link

Fixes missing jq on gke nodes issue #183 #186

Open Shaked opened 4 years ago

Shaked commented 4 years ago

Reason for Change:

GKE nodes (maybe others as well?) might not have jq installed and therefore will fail mounting the volume. See more at https://github.com/Azure/kubernetes-keyvault-flexvol/issues/183

Issue Fixed:

Fixes #183

Notes for Reviewers:

I have tested this solution on a GKE node. However, I haven't tested it on a node that does include jq.

I am not sure if using python is the best way, but I assume that python exists on all *nix machines and would be the easiest solution for the time being.

msftclas commented 4 years ago

CLA assistant check
All CLA requirements met.

Shaked commented 4 years ago

@aramase unfortunately, GKE nodes are based on Chromium OS, which will require the user to build a custom jq binary in order to install it and the automatically provision it. On the other hand, python is installed by default on almost all common *nix versions AFAIK.

As for the example that you have attached, if there is a possibility to install jq or python, we can let the user know in the error message about it (something like "jq or python is required for keyvault-flexvol to work")

aramase commented 4 years ago

@Shaked sounds good! I'll review and try out the PR soon.