search

Azure / kubernetes-keyvault-flexvol

Azure keyvault integration with Kubernetes via a Flex Volume
MIT License
253 stars 84 forks source link

Improved error wrapping and add support for object alias #85

Closed jon-walton closed 5 years ago

jon-walton commented 5 years ago

Hi,

I needed object aliases so this PR adds that. It works the same as described in concept.md. It also adds some improvements to the error wrapping that helped debugging my deployment

I did initially set the k8s config to be keyvaultobjectaliases until I saw concept.md, let me know if you want it renamed.

fixes #51 fixes #66

msftclas commented 5 years ago

CLA assistant check
All CLA requirements met.

ritazh commented 5 years ago

Thanks for your contribution @jon-walton 🎉 Will review this PR shortly.

ritazh commented 5 years ago

I did initially set the k8s config to be keyvaultobjectaliases until I saw concept.md, let me know if you want it renamed.

I think keyvaultobjectaliases is better as it is more consistent with other configs for each key vault object. Let's update this as concept.md is a bit out of date. Thanks @jon-walton!

jon-walton commented 5 years ago

thanks @ritazh , I've pushed a new commit containing your feedback